Review main Merged

94922Revert "[TASK] GifBuilder: Remove reference marker for `GdImage` parameters"

Andreas Kienast CR +2 V +2 Easy +23 −23 updated 07/24/26, 14:05

Commit message

This reverts commit f2b0de8c98146483b4b264f96b2ee8692c7ef005.

Reason for revert: GifBuilder explicitly expects references of objects
as they get re-assigned in some places. Due to the poor test coverage
it's advised to revert the offending patch.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Marvin Buchmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Marvin Buchmann +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Andreas Kienast uploaded patch set 1 07/24/26, 09:17

  2. Benni Mack voted on patch set 1 CR +1 07/24/26, 09:17

  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 07/24/26, 09:17

  4. core-ci voted on patch set 1 V +1 07/24/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105305

  5. Garvin Hicking commented on patch set 1 CR +1 V +1 07/24/26, 13:39

    It would be nice to maybe have a followup or so that adds a comment for this like `(intentional reference, gets reassigned)` instead of `(reference)` only?
  6. Andreas Kienast voted on patch set 1 CR +2 V +2 07/24/26, 13:57

  7. Marvin Buchmann voted on patch set 1 CR +1 V +1 07/24/26, 13:58

  8. Andreas Kienast merged patch set 2 07/24/26, 14:05