Review main Merged

94955[BUGFIX] Remove search term in file list search url

Alexander Künzl CR +2 V +2 Normal +172 −31 updated 09/14/26, 08:16

Commit message

When performing a search in the file list module,
the search term becomes part of the search
form's action url. When the search term changes,
the old search term is still part of the
action url, thus recreating the old search term.

The commit creates an own url for the search form,
without the search term.

The pagination url is built from explicit parameters
now as well, instead of reusing the query string of
the current request, which kept an outdated search
term alive in the paging links. The page selector
input uses that url instead of the form action, so
paging keeps an active search term.

This mirrors DatabaseRecordList, where the search
form leaves out "searchTerm" and "pointer".

Playwright tests cover the media module and the
records module, so both stay in sync.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1216

  1. Alexander Künzl uploaded patch set 1 07/27/26, 14:02

  2. core-ci voted on patch set 1 V +1 07/27/26, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105466

  3. Josua Vogel commented on patch set 1 07/30/26, 06:30

    FileList.php:1552

    createListUri could return null, this isn´t handled - at least you need to change the return parameter to ?string - same below at createSearchFormUri
  4. Alexander Künzl uploaded patch set 2 07/30/26, 06:54

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  5. core-ci voted on patch set 2 V +1 07/30/26, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105661

  6. Alexander Künzl uploaded patch set 3 V +1 07/30/26, 07:19

  7. core-ci voted on patch set 3 V +1 07/30/26, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105665

  8. Benni Mack voted on patch set 3 CR +1 09/01/26, 12:56

  9. Benni Mack commented on patch set 3 09/01/26, 14:20

    FileList.php:1552 Reply

    Done
  10. Josua Vogel voted on patch set 3 CR +1 V +1 09/01/26, 14:23

  11. Benni Mack uploaded patch set 4 CR +1 V +1 09/02/26, 11:47

  12. core-ci voted on patch set 4 V +1 09/02/26, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107616

  13. Georg Ringer voted on patch set 4 CR +1 V +1 09/09/26, 15:36

  14. Stefan Bürk voted on patch set 4 CR +1 V +1 09/14/26, 05:03

  15. Benni Mack voted on patch set 4 CR +2 V +2 09/14/26, 08:16

  16. Benni Mack merged patch set 5 09/14/26, 08:16