95036[TASK] Add functional tests for user authentication chain
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1215
-
Benni Mack uploaded patch set 1 07/31/26, 10:26
-
Benni Mack updated the commit message in patch set 2 07/31/26, 10:26
-
core-ci voted on patch set 1 V +1 07/31/26, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105749
-
core-ci voted on patch set 2 V +1 07/31/26, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105750
-
Benni Mack marked it ready for review 07/31/26, 11:13
-
Simon Schaufelberger commented on patch set 2 07/31/26, 13:11
-
Oliver Klee commented on patch set 2 V +1 07/31/26, 13:48
AbstractUserAuthenticationTest.php:76This is not necessary as the functional tests are configured to backup and restore globals: https://github.com/TYPO3/typo3/blob/main/Build/phpunit/FunctionalTests.xml#L17 -
Benni Mack uploaded patch set 3
V +107/31/26, 19:18 -
Benni Mack commented on patch set 3 07/31/26, 19:20
AbstractUserAuthenticationTest.php:76Replythx. done. I have a fork of the TF working against (I'm trying to add more speed to it), so I had some workarounds while doing this patch.FixtureAuthenticationService.php:43Replythat's by design, see the tests, I need to know which auth service is called and why and how often. -
Garvin Hicking voted on patch set 3 CR +1 V +1 07/31/26, 19:25
-
core-ci voted on patch set 3 V +1 07/31/26, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105758
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 07/31/26, 19:57
-
Oliver Klee voted on patch set 3 V +1 07/31/26, 20:38
-
Benni Mack voted on patch set 3 CR +2 V +2 08/01/26, 05:10
-
Benni Mack merged patch set 4 08/01/26, 05:11
FixtureAuthenticationService.php:43