9511[TASK] PHP 5.4 adjustments
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Sebastian Fischer +1
- Philipp Gampe +1
-
Verified V +2
- Steffen Ritter +2
- Philipp Gampe +1
Issues 1
Files 3
Review log 17
-
Markus Klein uploaded patch set 2 03/11/12, 11:48
-
Markus Klein uploaded patch set 3 03/11/12, 11:48
-
Markus Klein uploaded patch set 4 03/11/12, 11:48
-
Markus Klein commented on patch set 4 03/11/12, 11:48
Sorry for pushing that many bugs within this patch. I couldn't check this locally. Sorry. -
Markus Klein commented on patch set 4 03/11/12, 11:48
(1 inline comment) -
Markus Klein uploaded patch set 5 03/11/12, 11:48
-
Steffen Ritter commented on patch set 5 V 0 03/11/12, 11:48
by team member; Looks good to me, approved -
Sebastian Fischer commented on patch set 4 03/11/12, 11:48
Looks good to me, but someone else must approve -
Sebastian Fischer commented on patch set 5 03/11/12, 11:48
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 03/11/12, 11:48
(1 inline comment)class.tx_reports_reports_status_configurationstatus.php:60spaces -
Philipp Gampe commented on patch set 5 03/11/12, 11:48
Verified; Looks good to me, but someone else must approve Tested with PHP 5.3 only (Fedora 16). This needs an additional test with PHP 5.4. -
Mr. Jenkins commented on patch set 1 03/11/12, 11:48
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3535/ : FAILURE -
Mr. Jenkins commented on patch set 2 03/11/12, 11:48
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3536/ : FAILURE -
Mr. Jenkins commented on patch set 3 03/11/12, 11:48
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3537/ : FAILURE -
Mr. Jenkins commented on patch set 4 03/11/12, 11:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3538/ : SUCCESS -
Mr. Jenkins commented on patch set 5 03/11/12, 11:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3539/ : SUCCESS -
Steffen Ritter merged patch set 5 03/11/12, 11:48