Review main Merged

9511[TASK] PHP 5.4 adjustments

Markus Klein CR +2 V +2 Easy +19 −13 updated 06/03/13, 20:49

Commit message

Small adjustments for PHP 5.4 compatibility.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Sebastian Fischer +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Ritter +2
    • Philipp Gampe +1

Issues 1

Files 3

Review log 17

  1. Markus Klein uploaded patch set 2 03/11/12, 11:48

  2. Markus Klein uploaded patch set 3 03/11/12, 11:48

  3. Markus Klein uploaded patch set 4 03/11/12, 11:48

  4. Markus Klein commented on patch set 4 03/11/12, 11:48

    Sorry for pushing that many bugs within this patch. I couldn't check this locally. Sorry.
  5. Markus Klein commented on patch set 4 03/11/12, 11:48

    (1 inline comment)
  6. Markus Klein uploaded patch set 5 03/11/12, 11:48

  7. Steffen Ritter commented on patch set 5 V 0 03/11/12, 11:48

    by team member; Looks good to me, approved
  8. Sebastian Fischer commented on patch set 4 03/11/12, 11:48

    Looks good to me, but someone else must approve
  9. Sebastian Fischer commented on patch set 5 03/11/12, 11:48

    Looks good to me, but someone else must approve
  10. Philipp Gampe commented on patch set 4 03/11/12, 11:48

    (1 inline comment)

    class.tx_reports_reports_status_configurationstatus.php:60

    spaces
  11. Philipp Gampe commented on patch set 5 03/11/12, 11:48

    Verified; Looks good to me, but someone else must approve Tested with PHP 5.3 only (Fedora 16). This needs an additional test with PHP 5.4.
  12. Mr. Jenkins commented on patch set 1 03/11/12, 11:48

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3535/ : FAILURE
  13. Mr. Jenkins commented on patch set 2 03/11/12, 11:48

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3536/ : FAILURE
  14. Mr. Jenkins commented on patch set 3 03/11/12, 11:48

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3537/ : FAILURE
  15. Mr. Jenkins commented on patch set 4 03/11/12, 11:48

  16. Mr. Jenkins commented on patch set 5 03/11/12, 11:48

  17. Steffen Ritter merged patch set 5 03/11/12, 11:48