Review main Merged

9529[BUGFIX] Remove "create new content element" in docheaders

Felix Kopp CR +2 V +2 Easy +8 −8 updated 06/03/13, 20:49

Commit message

Removes icon in docheader in page backend module to create new
content element. That icon is present in content columns.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Steffen Ritter +2
    • Max Roesch +1
    • Philipp Gampe +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Steffen Ritter +2
    • Max Roesch +1
    • Philipp Gampe +1

Files 1

Review log 13

  1. Steffen Ritter merged patch set 1 04/13/12, 10:02

  2. Tolleiv Nietsch commented on patch set 1 V 0 04/13/12, 10:02

    by team member; Looks good to me, approved Steffen --- this does what the UI team decided so I'd say it's good to go this way ...?
  3. Steffen Ritter commented on patch set 1 V 0 04/13/12, 10:02

    by team member; Looks good to me, approved
  4. Steffen Ritter commented on patch set 1 04/13/12, 10:02

    I would prefer that you didn't submit this I'm not sure about this. I do not think it is a good idea, since the "create new record" is present in list module, too. The "general" look and feel would be broken. Please check with ui team
  5. Max Roesch voted on patch set 1 V 0 04/13/12, 10:02

  6. Max Roesch commented on patch set 1 04/13/12, 10:02

    Looks good to me, but someone else must approve
  7. Philipp Gampe commented on patch set 1 04/13/12, 10:02

    Verified; Looks good to me, but someone else must approve
    IMHO this should be TASK. Bugfixes are something fixing something broken to me.
  8. Felix Kopp commented on patch set 1 04/13/12, 10:02

    He Steffen, thanks for your input - I see your concerns, but please see Forge for UI team feedback. This patch fixes an issues which is exactly one year old. Please feedback
  9. Felix Kopp commented on patch set 1 04/13/12, 10:02

    Steffen, anything new?
  10. Felix Kopp commented on patch set 1 04/13/12, 10:02

    This patch was accepted on 18.10.2010 (http://forge.typo3.org/issues/10307#note-1) Please remove your -1 or at least comment
  11. Felix Kopp commented on patch set 1 04/13/12, 10:02

    New buttons are added in https://review.typo3.org/#/c/10318/. Can we please get this issue solved?
  12. Mr. Jenkins commented on patch set 1 04/13/12, 10:02

  13. Steffen Ritter commented on patch set 1 04/13/12, 10:02

    Submitted it - but this cannot go to 4.7 anymore.