Review main Merged

95361[TASK] Consider all database fields when querying FAL resources

Elias Häußler CR +2 V +2 Easy +6 −6 updated 09/01/26, 08:51

Commit message

With #107776, the list of queried `sys_file` fields was limited to a
fixed field set, making it impossible for consumers to query additional
fields, e.g. when `sys_file` is extended by additional metadata. Even
if the class is marked as internal, defining and querying additional
fields is a valid use-case, which is why the list of selected fields
must be extensible in some way. In order to be more flexible in this
area, the select fields are now no longer limited – instead, all
available fields are now queried.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1

Issues 2

Files 1

Review log 1216

  1. Elias Häußler uploaded patch set 1 08/18/26, 06:04

  2. Elias Häußler uploaded patch set 2 08/18/26, 06:11

  3. core-ci voted on patch set 2 V +1 08/18/26, 06:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106854

  4. core-ci voted on patch set 1 V -1 08/18/26, 07:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106853

  5. Oliver Klee updated the commit message in patch set 3 V +1 08/18/26, 08:00

  6. Oliver Klee voted on patch set 3 CR +1 08/18/26, 08:00

  7. core-ci voted on patch set 3 V +1 08/18/26, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106856

  8. Georg Ringer voted on patch set 3 CR +1 V +1 08/18/26, 09:52

  9. Torben Hansen voted on patch set 3 CR +1 V +1 08/20/26, 10:38

  10. Elias Häußler uploaded patch set 4 CR +1 V +1 09/01/26, 08:36

  11. Oliver Klee voted on patch set 4 CR +1 09/01/26, 08:37

  12. Elias Häußler commented on patch set 4 09/01/26, 08:40

    Note: 14.3 backport is slightly different due to #110546.
  13. Torben Hansen voted on patch set 4 CR +1 V +1 09/01/26, 08:41

  14. Benni Mack voted on patch set 4 CR +2 V +2 09/01/26, 08:48

  15. Benni Mack merged patch set 5 09/01/26, 08:48

  16. core-ci voted on patch set 4 V +1 09/01/26, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107473