Review main Abandoned

9551[BUGFIX] Adds backticks to field and table names

Nico de Haen CR 0 V 0 Easy +15 −16 updated 06/12/13, 10:26

Commit message

SQL queries generated by Install tool and Extension manager missed backticks

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    *ping*
  2. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Jenkins complained about line-length of commit-msg. Patch still valid. File is meanwhile: typo3/sysext/install/Classes/Sql/SchemaMigrator.php
  3. Xavier Perseguers commented on patch set 1 05/27/13, 17:19

    Will have a look. If there are no unit tests currently for this case, I'll add them to be sure.
  4. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    (1 inline comment) Does this change work with dbal too?
    A releases line is missing abd the line max char limit per line is exceeded (that is the Jenkins error).
  5. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/3558/ : FAILURE
  6. Nico de Haen commented on patch set 1 06/12/13, 10:26

    I just found the duplicate #35253 which is in review already
  7. Nico de Haen abandoned the change 06/12/13, 10:26

    I just found the duplicate #35253 which is in review already