Review main Merged

9559[FEATURE] Insert hook into form wizard view

Franz Geiger CR +2 V +2 Easy +22 −1 updated 06/03/13, 20:49

Commit message

Introduces a hook in tx_form_View_Wizard_Wizard. This hook
allows extending the wizard interface by loading extending
resources. The hook is executed after all other resources have
been loaded and just before content rendering.

Use it by adding your function to the array
$TYPO3_CONF_VARS['EXTCONF']['form']['hooks']['renderWizard']

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 1

Review log 17

  1. Mr. Jenkins commented on patch set 1 04/01/12, 16:26

  2. Wouter Wolters commented on patch set 1 04/01/12, 16:26

    (4 inline comments) Some small remarks
    Resolves here. Fixes is for a bugfix. See http://wiki.typo3.org/CommitMessage_Format_%28Git%29

    Wizard.php:346

    One more tab before $funcRefs and $param

    Wizard.php:352

    foreach( -> foreach (

    Wizard.php:354

    Add a space after the , $funcRef, $param, $this
  3. Mr. Jenkins commented on patch set 2 04/01/12, 16:26

  4. Franz Geiger uploaded patch set 2 04/01/12, 16:26

  5. Philipp Gampe commented on patch set 3 04/01/12, 16:26

    (1 inline comment)
  6. Philipp Gampe commented on patch set 3 04/01/12, 16:26

    Must be 4.8 now
  7. Mr. Jenkins commented on patch set 3 04/01/12, 16:26

  8. Franz Geiger uploaded patch set 3 04/01/12, 16:26

  9. Andreas Wolf uploaded patch set 6 04/01/12, 16:26

  10. Georg Ringer commented on patch set 5 04/01/12, 16:26

    Looks good to me, but someone else must approve
  11. Philipp Gampe commented on patch set 5 04/01/12, 16:26

    Verified; Looks good to me, but someone else must approve I moved the change-id line up and slightly modified the wording of the commit message and the phpdoc.
  12. Philipp Gampe uploaded patch set 5 04/01/12, 16:26

  13. Mr. Jenkins commented on patch set 4 04/01/12, 16:26

  14. Mr. Jenkins commented on patch set 5 04/01/12, 16:26

  15. Franz Geiger uploaded patch set 4 04/01/12, 16:26

  16. Andreas Wolf commented on patch set 6 V 0 04/01/12, 16:26

    by team member; Looks good to me, approved Did some small modifications (naming cleanup); merging after my review.
  17. Andreas Wolf merged patch set 6 04/01/12, 16:26