Review main Merged

95592[TASK] Protect SystemEmail CSS from Fluid parsing

Josua Vogel CR +2 V +2 Easy +30 −2 updated 09/28/26, 17:08

Commit message

Wrap the inline CSS in Fluid's CDATA syntax so curly braces no longer
alter the parser state. This allows custom variables directly after the
body tag without rendering the complete CSS block through format.raw.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1416

  1. Josua Vogel uploaded patch set 1 09/03/26, 08:20

  2. core-ci voted on patch set 1 V +1 09/03/26, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107727

  3. Simon Schaufelberger commented on patch set 1 09/03/26, 08:31

    FluidEmailTest.php:91

    this check is pretty useless, or?
  4. Josua Vogel commented on patch set 1 09/03/26, 08:40

    FluidEmailTest.php:91 Reply

    You can look at it however you want :D It's just another explicit check, but the previous assertion theoretically covers it.
  5. Simon Schaufelberger commented on patch set 1 09/03/26, 08:55

    FluidEmailTest.php:91 Reply

    I just wonder where it theoretically could come from.
  6. Josua Vogel commented on patch set 2 V +1 09/03/26, 09:12

    Published edit on patch set 1.
  7. Josua Vogel commented on patch set 2 09/03/26, 09:13

    FluidEmailTest.php:91 Reply

    Removed to avoid unnecessary discussions. The test is not necessary. 😊
  8. core-ci voted on patch set 2 V +1 09/03/26, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107732

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/03/26, 10:10

  10. Oliver Klee voted on patch set 2 CR +1 V +1 09/03/26, 10:17

  11. Garvin Hicking commented on patch set 2 09/28/26, 14:40

    Did you by chance test if this affects outlook / word97 html rendering?
  12. Josua Vogel commented on patch set 2 09/28/26, 14:42

    Reply

    no :)
  13. Garvin Hicking commented on patch set 2 09/28/26, 15:26

    Reply

    Ah maybe fluid already strips that away. Would need to check this (or someone else). If the cdata ends up in the mails it could be trouble, trouble, trouble.
  14. Josua Vogel commented on patch set 2 09/28/26, 15:35

    Reply

    I think it´s removed: https://github.com/TYPO3/Fluid/pull/1246#issue-3506241623 I can check this later
  15. Garvin Hicking commented on patch set 2 CR +2 V +2 09/28/26, 15:40

    Reply

    Yes, test also proves this as you just said. I'll merge later.
  16. Garvin Hicking merged patch set 3 09/28/26, 17:08