95592[TASK] Protect SystemEmail CSS from Fluid parsing
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1416
-
Josua Vogel uploaded patch set 1 09/03/26, 08:20
-
core-ci voted on patch set 1 V +1 09/03/26, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107727
-
Simon Schaufelberger commented on patch set 1 09/03/26, 08:31
-
Josua Vogel commented on patch set 1 09/03/26, 08:40
FluidEmailTest.php:91ReplyYou can look at it however you want :D It's just another explicit check, but the previous assertion theoretically covers it. -
Simon Schaufelberger commented on patch set 1 09/03/26, 08:55
FluidEmailTest.php:91ReplyI just wonder where it theoretically could come from. -
Josua Vogel commented on patch set 2
V +109/03/26, 09:12Published edit on patch set 1. -
Josua Vogel commented on patch set 2 09/03/26, 09:13
FluidEmailTest.php:91ReplyRemoved to avoid unnecessary discussions. The test is not necessary. 😊 -
core-ci voted on patch set 2 V +1 09/03/26, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107732
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/03/26, 10:10
-
Oliver Klee voted on patch set 2 CR +1 V +1 09/03/26, 10:17
-
Garvin Hicking commented on patch set 2 09/28/26, 14:40
Did you by chance test if this affects outlook / word97 html rendering? -
Josua Vogel commented on patch set 2 09/28/26, 14:42
Reply
no :) -
Garvin Hicking commented on patch set 2 09/28/26, 15:26
Reply
Ah maybe fluid already strips that away. Would need to check this (or someone else). If the cdata ends up in the mails it could be trouble, trouble, trouble. -
Josua Vogel commented on patch set 2 09/28/26, 15:35
Reply
I think it´s removed: https://github.com/TYPO3/Fluid/pull/1246#issue-3506241623 I can check this later -
Garvin Hicking commented on patch set 2 CR +2 V +2 09/28/26, 15:40
Reply
Yes, test also proves this as you just said. I'll merge later. -
Garvin Hicking merged patch set 3 09/28/26, 17:08
FluidEmailTest.php:91