Review main Merged

95606[BUGFIX] Do not shrink images to minWidth/minHeight

Maike Kiebele CR +2 V +2 Easy +30 −2 updated 09/10/26, 08:10

Commit message

Without an explicit width or height, images were always resized
down to the given minWidth/minHeight, even if they were already
larger.

`ImageProcessingInstructions::fromCropScaleValues()` compared the
placeholder for "no width/height given" directly against
minWidth/minHeight. The check now only does that when a width or
height is actually given.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Maike Kiebele uploaded patch set 1 09/03/26, 13:57

  2. core-ci voted on patch set 1 V +1 09/03/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107760

  3. Benni Mack voted on patch set 1 CR +1 V +1 09/09/26, 09:14

  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/10/26, 07:00

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/10/26, 07:16

  6. Oliver Klee voted on patch set 1 V +1 09/10/26, 07:19

  7. Benni Mack voted on patch set 1 CR +2 V +2 09/10/26, 08:10

  8. Benni Mack merged patch set 2 09/10/26, 08:10