Review TYPO3_4-5 Merged

957[BUGFIX] Pages with Enforce Protocol (SSL) may generate wrong URL

Steffen Ritter CR +2 V +1 Easy +5 −0 updated 06/03/13, 20:49

Commit message

If TYPO3 is installed in a subfolder, you won't need a absRefPrefix set because normally links are relative.
If a Protocol change will (SSL -> PLAIN or vice versa) happen, the URL has to be generated absolute.
This will fail in the described behaviour.

Notes:
This one has been reported by Michael Maier.
Attached patch is my "easier to read" version doing the same as _v2 of Jigal and the result of talking through all cases which may arise.

Resolves: #M17118
Master Branch: Ie5821361b578b6f1fa3612ac9bfa44dd476c9c76

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +1
    • Jigal van Hemert +1

Files 1

Review log 4

  1. Peter Niederlag commented on patch set 1 03/12/11, 07:08

    I would prefer that you didn't submit this please hang on (aka dont press submit), as we want to keep this as an example for a "commit on mutiple branches" test/review..
  2. Steffen Ritter commented on patch set 1 03/12/11, 07:08

    this patch has been merged to, trunk without modification. Please step in and vote for 4-5 branch - it's the same
  3. Jigal van Hemert commented on patch set 1 03/12/11, 07:08

    Verified; Looks good to me, approved Nothing has changed in this part of the code since 4.5 came out. Tested it again and it still works.
  4. Jigal van Hemert merged patch set 1 03/12/11, 07:08