Review main Merged

95859[BUGFIX] Support schemeless URLs in forceAbsoluteUrl()

Maike Kiebele CR +2 V +2 Easy +19 −1 updated 10/07/26, 14:37

Commit message

With typolink.forceAbsoluteUrl = 1, URLs are turned into
absolute URLs - except schemeless URLs, which got the
current request's scheme and host prepended instead of
keeping their own host. This happened because the regex
required scheme and host to match as one block, so a
schemeless URL like "//example.org/foo" was not recognized
as having a host either.

Scheme and host are now matched as two independent, optional
parts, so the "://" delimiter is only added when a scheme
is actually present.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Maike Kiebele uploaded patch set 1 09/15/26, 13:54

  2. core-ci voted on patch set 1 V +1 09/15/26, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108627

  3. Georg Ringer voted on patch set 1 CR +1 V +1 09/16/26, 05:52

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 09/16/26, 11:32

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 09/16/26, 17:05

  6. Georg Ringer voted on patch set 1 CR +2 V +2 10/07/26, 14:37

  7. Georg Ringer merged patch set 2 10/07/26, 14:37