Review main Merged

95879[BUGFIX] Keep storage filters in Folder->getFiles()

Georg Ringer CR +2 V +2 Easy +23 −6 updated 09/28/26, 10:12

Commit message

FILTER_MODE_NO_FILTERS took a shortcut that backed up an empty
filter array instead of null. Restoring it afterwards overwrote
the storage filters with an empty array, silently dropping the
default filters for the rest of the request.

prepareFiltersInStorage() already returns [null, false] for that
mode, so the shortcut is removed and getFiles() now behaves like
getSubfolders() and searchFiles().

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stephan Großberndt +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Georg Ringer uploaded patch set 1 09/16/26, 15:17

  2. Georg Ringer commented on patch set 1 09/16/26, 15:17

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 09/16/26, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108700

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 09/16/26, 15:28

  5. Oliver Klee voted on patch set 1 CR +1 V +1 09/16/26, 15:40

  6. Stephan Großberndt voted on patch set 1 CR +1 09/17/26, 10:29

  7. Benni Mack voted on patch set 1 CR +2 V +2 09/28/26, 10:12

  8. Benni Mack merged patch set 2 09/28/26, 10:12