960[BUGFIX] New EM, Date of last update not visible due to missing
Commit message
Review
-
Code review CR +2
- Steffen Kamper +2
-
Verified V +1
- Steffen Kamper +1
Files 1
Review log 12
-
Peter Niederlag commented on patch set 1 03/22/11, 10:51
if you update a patch/change: * use the same Change-Id (!!) * for single/simple patches just 'edit file, git add, git commit --amend' to do the "same" commit differentem_layouts.js:127<the opening span start and end is hard to recognize>, also I am testing an inline comment -
Peter Niederlag uploaded patch set 2 03/22/11, 10:51
-
Peter Niederlag commented on patch set 2 1 comment 03/22/11, 10:51
Looks good to me, but someone else must approve seems reasonable to me -
Dmitry Dulepov commented on patch set 2 03/22/11, 10:51
I would prefer that you didn't submit this Localization strings should be handled differently. Concatenation of string parts should not happen. This is not good: TYPO3.lang.extensions_repository_short + ' {count}</span>' Different languages may require the counter to be placed in the other position. The correct would be to include the counter into the string and format the whole message. So instead of: <label index="extensions_repository_short">Extensions in repository:</label> you should have: <label index="extensions_repository_short">Extensions in repository: {count}</label> in ./typo3/sysext/em/language/locallang.xml. This would allow proper localization. Even english users would prefer a more natural "There are 5 extension(s) in repository". If you are in doubt, remember a classic example: $content = $this->pi_getLL('Page') . ' ' . $pageNumber . ' ' . $this->pi_getLL('of') . ' ' . $totalPages; The example above is not translatable to most languages. The proper code is: $content = sprintf($this->pi_getLL('Page_x_of_n'), $pageNumber, $totalPages); <label index="Page_x_of_N">Page %1$d of %2$d</label> Also you have two for formatting. Is that necessary? It does not look clean. Sorry for neatpicking. -
Steffen Kamper commented on patch set 2 03/22/11, 10:51
@Dmitry: i know that for normal textmessages, but this is clearly seperated, same way as the Info in extensions: <label>: value We have this at several places, so i don't see the need to encapsualate the value into the label for this output. @Tobi: inline style is needed to display it proper, i use a not general div for this display. Can be changed later i think, but not part of this change -
Steffen Kamper uploaded patch set 3 03/22/11, 10:51
-
Tobias Liebig commented on patch set 2 03/22/11, 10:51
(1 inline comment)... missing spaceem_layouts.js:127do we really need a inline-style here? -
Tobias Liebig commented on patch set 2 03/22/11, 10:51
(1 inline comment) -
Steffen Ritter commented on patch set 1 03/22/11, 10:51
Do not submit Hello Steffen, your FIX splits about two commits, therefore there are to gerrit requests. Furthermore your commit-message does not match th estyle we agreed to. -
Steffen Ritter commented on patch set 2 03/22/11, 10:51
Looks good to me, approved thanks Peter for cleaning up the push -
Steffen Kamper commented on patch set 3 03/22/11, 10:51
Verified; Looks good to me, approved changed all requested details. -
Steffen Kamper merged patch set 3 03/22/11, 10:51