Review main Merged

96054[BUGFIX] Cut indexed words by characters instead of bytes

Benni Mack CR +2 V +2 Easy +13 −1 updated 09/25/26, 15:55

Commit message

Indexer->analyzeBody() shortens words to 60 characters, the length of
the index_words.baseword field, with substr(). This works on bytes, so
words with multi-byte characters are cut in the middle of a character
and the word id is calculated from an invalid string. The analysis of
the header information already uses mb_substr().

Use mb_substr() for the body as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 09/25/26, 01:46

  2. core-ci voted on patch set 1 V +1 09/25/26, 02:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109200

  3. Josua Vogel voted on patch set 1 CR +1 09/25/26, 05:09

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 09/25/26, 15:23

  5. Benni Mack voted on patch set 1 CR +2 V +2 09/25/26, 15:55

  6. Benni Mack merged patch set 2 09/25/26, 15:55