Review main Merged

96056[BUGFIX] Limit stored word count to the size of the database field

Benni Mack CR +2 V +2 Easy +14 −1 updated 09/25/26, 16:54

Commit message

The field index_rel.count is an unsigned tinyint, but the number of
occurrences of a word in a document is inserted without a limit. A word
that occurs more than 255 times in a page or a file fails the insert
or is stored as a wrong value, depending on the SQL mode of the
database server.

Limit the stored count to 255. The frequency of the word is still
calculated from the real number of occurrences.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 09/25/26, 01:46

  2. core-ci voted on patch set 1 V +1 09/25/26, 02:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109202

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 09/25/26, 15:22

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 09/25/26, 16:40

  5. Benni Mack voted on patch set 1 CR +2 V +2 09/25/26, 16:54

  6. Benni Mack merged patch set 2 09/25/26, 16:54