Review main Merged

96059[BUGFIX] Avoid "-INF%" as rating of search results

Benni Mack CR +2 V +2 Normal +51 −2 updated 09/25/26, 06:46

Commit message

The RatingViewHelper calculates the relevance of a search result with
a logarithm of the ranking value. If the value is 0, log() returns
negative infinity, which is rendered as "-INF%". This happens for
results sorted by frequency with an order value of 0 and for results
sorted by flags without a rating.

Limit the ranking value to a minimum of 1, so that the rating is 0%.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack uploaded patch set 1 09/25/26, 01:46

  2. core-ci voted on patch set 1 V +1 09/25/26, 02:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109205

  3. Georg Ringer voted on patch set 1 CR +1 V +1 09/25/26, 05:02

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 09/25/26, 06:37

  5. Stefan Bürk merged patch set 2 09/25/26, 06:46