Review 14.3 Merged

96090[BUGFIX] Handle parallel processing folder creation

Garvin Hicking CR +2 V +2 Normal +74 −1 updated 09/25/26, 18:53

Commit message

ResourceStorage::getProcessingFolder() checks whether the processing
folder exists and creates it afterwards. A parallel request can
create that very folder in between, so createFolder() throws an
ExistingTargetFolderException that nobody catches and the request
dies.

The exception is now caught in both branches - for the processing
folder of the storage itself and for one that points to another
storage - and the folder that is already there is used, just like
getNestedProcessingFolder() does since #96727.

Restoring the previous permission evaluation moves into a finally
block, so it happens even when creating the folder fails.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 09/25/26, 18:30

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/25/26, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109292

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 09/25/26, 18:52

  4. Garvin Hicking merged patch set 2 09/25/26, 18:53