Review main Merged

96118[TASK] Clarify site matching for relative base URLs

Wouter Wolters CR +2 V +2 Easy +29 −5 updated 09/30/26, 07:18

Commit message

Replace the stale random-result TODO with an explicit assertion for
the site whose relative base matches any host.

Cover the opposite case: an unknown host does not match a site with
only an absolute base URL.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Wouter Wolters uploaded patch set 1 09/27/26, 19:54

  2. core-ci voted on patch set 1 V -1 09/27/26, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109377

  3. Wouter Wolters uploaded patch set 2 V -1 09/27/26, 20:06

  4. core-ci voted on patch set 2 V +1 09/27/26, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109378

  5. Benni Mack voted on patch set 2 CR +1 V +1 09/30/26, 06:48

  6. Georg Ringer voted on patch set 2 CR +2 V +2 09/30/26, 07:06

  7. Georg Ringer merged patch set 3 09/30/26, 07:18