Review main Ready for review Quiet

96264[BUGFIX] Show login in EM toggle on expired session

Olivier Dobberkau CR 0 V 0 Normal +54 −3 updated 10/19/26, 14:01

Commit message

With an expired backend session, the requests of the extension
toggle button are redirected to the login form. fetch() follows the
redirect, so the button received HTML instead of JSON, still opened
the confirmation dialog and then silently did nothing. The backend
only checks for an expired session once a minute, so a click in a
restored browser window is usually faster.

The button now detects a redirected or non-JSON response and opens
the login form of the backend right away. After logging in, the
action can be repeated without reloading the page.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/64/96264/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/64/96264/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 2

Issues 1

Files 3

Review log 69

  1. Olivier Dobberkau uploaded patch set 1 10/01/26, 16:46

  2. Olivier Dobberkau commented on patch set 1 10/01/26, 16:48

    Unresolved

    AI-assisted contribution: prepared with Claude Code under my supervision. I reviewed every line of the diff, ran lintTypescript, build, normalizeXliff, checkIntegrityXliff and the e2e spec (classic and composer mode) locally and take responsibility for this change.
  3. core-ci voted on patch set 1 V +1 10/01/26, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109817

  4. Olivier Dobberkau uploaded patch set 2 V +1 10/01/26, 22:02

  5. Olivier Dobberkau commented on patch set 2 10/01/26, 22:03

    Unresolved

    Patch set 2 opens the backend login form (LoginRefresh) instead of showing an error notification, closer to what #110066 asks for: the session check of the backend runs only once a minute, so a click in a restored window was faster than it. After logging in, the action can be repeated without a reload. No new labels any more. AI-assisted contribution: prepared with Claude Code under my supervision. I reviewed every line of the diff, ran build, lintTypescript, normalizeXliff, checkIntegrityXliff and the e2e spec (classic and composer mode) locally and take responsibility for this change.
  6. core-ci voted on patch set 2 V +1 10/01/26, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109848

  7. Olivier Dobberkau uploaded patch set 3 V +1 10/19/26, 12:55

  8. core-ci voted on patch set 3 V +1 10/19/26, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111645

  9. Georg Ringer commented on patch set 3 10/19/26, 14:01

    is that only related to EM? IMO there are a couple of issues about that. maybe it makes sense to fix that more on a global level if possible?