Review main Merged

96281[BUGFIX] Respect abort override in pre-commit hook

Olivier Dobberkau CR +2 V +2 Easy +1 −1 updated 10/08/26, 07:58

Commit message

The pre-commit hook reads TYPO3_GIT_HOOK_ABORT_ON_ERROR only when the
variable is unset, because the check used -z instead of -n. Setting it
to "yes" therefore never aborted a commit on CGL or file header errors,
and leaving it unset cleared the "no" default.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Olivier Dobberkau uploaded patch set 1 10/01/26, 22:37

  2. Olivier Dobberkau commented on patch set 1 10/01/26, 22:41

    AI-assisted contribution: prepared with Claude Code under my supervision. I reviewed the diff and verified the variable handling of the hook before and after the change (unset, "yes", "no"), and take responsibility for this change.
  3. core-ci voted on patch set 1 V +1 10/01/26, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109851

  4. Garvin Hicking commented on patch set 1 CR +2 V +2 10/08/26, 07:44

    Verified working on my macOS bash `GNU bash, version 5.3.20(1)-release (aarch64-apple-darwin25.6.0)`

    Reply

    Done
  5. Garvin Hicking merged patch set 2 10/08/26, 07:58