Review 13.4 Merged

96483[BUGFIX] Support schemeless URLs in forceAbsoluteUrl()

Georg Ringer CR +2 V +2 Easy +19 −1 updated 10/07/26, 14:37

Commit message

With typolink.forceAbsoluteUrl = 1, URLs are turned into
absolute URLs - except schemeless URLs, which got the
current request's scheme and host prepended instead of
keeping their own host. This happened because the regex
required scheme and host to match as one block, so a
schemeless URL like "//example.org/foo" was not recognized
as having a host either.

Scheme and host are now matched as two independent, optional
parts, so the "://" delimiter is only added when a scheme
is actually present.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Georg Ringer uploaded patch set 1 10/07/26, 14:25

  2. Georg Ringer commented on patch set 1 10/07/26, 14:25

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/07/26, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110338

  4. Georg Ringer voted on patch set 1 CR +2 V +2 10/07/26, 14:37

  5. Georg Ringer merged patch set 2 10/07/26, 14:37