96654[BUGFIX] Transform number fields to float|int in RecordFieldTransformer
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1013
-
Benjamin Franzke uploaded patch set 1 10/13/26, 05:09
-
core-ci voted on patch set 1 V +1 10/13/26, 05:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110968
-
Daniel Windloff commented on patch set 1 10/13/26, 05:37
-
Benjamin Franzke uploaded patch set 2
V +110/13/26, 06:03 -
Benjamin Franzke commented on patch set 2 10/13/26, 06:03
RecordFieldTransformer.php:195Replythanks, done! -
Oli Bartsch commented on patch set 2 10/13/26, 06:10
RecordFieldTransformerTest.php:1168Do you think it would make sense to explicitly check that this returns as float? -
core-ci voted on patch set 2 V +1 10/13/26, 06:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110971
-
Benjamin Franzke commented on patch set 2 10/13/26, 06:15
RecordFieldTransformerTest.php:1168ReplyI think it is checked, since it compares to `12.0` (changing that to `12` would let the test fail). Or do you mean something else? -
Benjamin Franzke updated the commit message in patch set 3
V +110/13/26, 06:16 -
core-ci voted on patch set 3 V +1 10/13/26, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110974
-
Oli Bartsch commented on patch set 3 CR +1 V +1 10/13/26, 06:56
RecordFieldTransformerTest.php:1168ReplyI though about `is_float` but I think that makes no sense. Just forget about it. :D -
Benjamin Franzke voted on patch set 3 CR +2 V +2 10/13/26, 07:04
-
Benjamin Franzke merged patch set 4 10/13/26, 07:04
RecordFieldTransformer.php:195