Review main Merged

96820[BUGFIX] Ignore empty time values for record icon overlays

Benni Mack CR +2 V +2 Normal +77 −13 updated 10/21/26, 05:05

Commit message

Since record rows in FormEngine carry DateTime objects, the overlay
calculation compares starttime and endtime strictly against integer
zero. New records may still carry raw default values like "0" or ""
for these columns, which then counted as an expired endtime and
rendered the "endtime" overlay on new inline children.

Empty values are now normalized to integers again, as before.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Benni Mack uploaded patch set 1 10/18/26, 14:04

  2. core-ci voted on patch set 1 V +1 10/18/26, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111529

  3. Benni Mack marked it ready for review 10/18/26, 14:26

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 10/18/26, 14:48

  5. Oliver Klee voted on patch set 1 CR +1 V +1 10/18/26, 15:15

  6. Georg Ringer voted on patch set 1 CR +1 V +1 10/20/26, 15:34

  7. Benni Mack voted on patch set 1 CR +2 V +2 10/21/26, 05:05

  8. Benni Mack merged patch set 2 10/21/26, 05:05