Review main Merged

96835[BUGFIX] Handle URIs without host in site matching

Benni Mack CR +2 V +2 Easy +27 −1 updated 10/18/26, 18:25

Commit message

RequestContextFactory::fromUri() passed an empty host to
idn_to_ascii(), which throws a ValueError since PHP 8. Requests
with a host-less URI, e.g. frontend sub-requests, crashed in
SiteResolver instead of resolving to a NullSite.

The empty host is now guarded the same way fromServerRequest()
already does it.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 10/18/26, 17:26

  2. Benni Mack marked it ready for review 10/18/26, 17:27

  3. core-ci voted on patch set 1 V +1 10/18/26, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111548

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 10/18/26, 17:42

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 10/18/26, 18:06

  6. Garvin Hicking merged patch set 2 10/18/26, 18:25