Review main Merged

96894[BUGFIX] Sort subpages by creation date

Himanshu Nitsan CR +2 V +2 Normal +101 −1 updated 10/22/26, 17:33

Commit message

The Create-time button submitted newSortBy=create. The
sort controller only accepts crdate, so the order never
changed. The button now submits crdate, and pages that
share a creation timestamp are ordered by uid.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1013

  1. Himanshu Nitsan uploaded patch set 1 10/20/26, 05:35

  2. core-ci voted on patch set 1 V +1 10/20/26, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111743

  3. Simon Schaufelberger commented on patch set 1 10/20/26, 08:36

    SortSubPagesControllerTest.php:42

    I'm not a big fan of HTML crawling and would leave out this test
  4. Himanshu Nitsan uploaded patch set 2 V +1 10/20/26, 10:19

  5. Himanshu Nitsan commented on patch set 2 10/20/26, 10:20

    SortSubPagesControllerTest.php:42 Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/20/26, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111791

  7. Benni Mack uploaded patch set 3 V +1 10/22/26, 16:45

  8. Benni Mack voted on patch set 3 CR +1 V +1 10/22/26, 16:49

  9. Matthias Vogel voted on patch set 3 CR +1 V +1 10/22/26, 16:52

  10. core-ci voted on patch set 3 V +1 10/22/26, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112155

  11. Wouter Wolters voted on patch set 3 CR +1 V +1 10/22/26, 16:57

  12. Benni Mack voted on patch set 3 CR +2 V +2 10/22/26, 17:33

  13. Benni Mack merged patch set 4 10/22/26, 17:33