Review main Merged

96903[BUGFIX] Report malformed site set definitions as invalid sets

Oli Bartsch CR +2 V +2 Normal +74 −3 updated 10/20/26, 16:06

Commit message

A config.yaml of a site set that is no mapping, or whose name is no
string, ran into a TypeError instead of an InvalidSetException. The
error escaped the set collection and broke building the set registry
as a whole, instead of disabling the one broken set.

Both are now checked right after the file is parsed, and reported
with the file they occur in. For sets without a usable name, the
file also identifies the error, so all malformed sets can be
reported together.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Oli Bartsch uploaded patch set 1 10/20/26, 08:51

  2. core-ci voted on patch set 1 V +1 10/20/26, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111767

  3. Matthias Vogel uploaded patch set 2 V +1 10/20/26, 13:08

  4. Matthias Vogel voted on patch set 2 CR +1 V +1 10/20/26, 13:08

  5. core-ci voted on patch set 2 V -1 10/20/26, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111824

  6. Matthias Vogel uploaded patch set 3 CR +1 V +1 10/20/26, 13:31

  7. Matthias Vogel voted on patch set 3 CR +1 V +1 10/20/26, 13:32

  8. core-ci voted on patch set 3 V +1 10/20/26, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111836

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 10/20/26, 14:37

  10. Oli Bartsch voted on patch set 3 CR +2 V +2 10/20/26, 16:06

  11. Oli Bartsch merged patch set 4 10/20/26, 16:06