Review main Merged

96904[BUGFIX] Disable site sets with circular dependencies

Oli Bartsch CR +2 V +2 Normal +212 −3 updated 10/20/26, 16:05

Commit message

Site sets depending on each other, directly or through other sets,
made the set registry recurse until PHP ran out of memory or stack,
before the dependency ordering could report the cycle.

The dependency check now tracks the sets on its way, and every set
in or depending on a cycle is disabled with an error naming the
cycle, the same way a set with a missing dependency is disabled.
Optional dependencies are taken into account, since they take part
in the ordering as well.

Sets with missing required dependencies are excluded before checking
for cycles, so unavailable optional sets do not disable otherwise
valid sets. Successful cycle checks are reused for shared dependencies
to avoid exponential traversal of valid dependency graphs.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 68

  1. Oli Bartsch uploaded patch set 1 10/20/26, 08:51

  2. core-ci voted on patch set 1 V +1 10/20/26, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111768

  3. Matthias Vogel uploaded patch set 2 V +1 10/20/26, 12:21

  4. Matthias Vogel voted on patch set 2 CR +1 V +1 10/20/26, 12:23

  5. core-ci voted on patch set 2 V +1 10/20/26, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111803

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 10/20/26, 14:50

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 10/20/26, 16:05

  8. Oli Bartsch merged patch set 3 10/20/26, 16:05