Review main Merged

96984[BUGFIX] Count skipped files as finished uploads

Oli Bartsch CR +2 V +2 Normal +123 −13 updated 10/23/26, 05:59

Commit message

When files already exist in the target folder, the drag uploader asks
how to handle them. Files that were skipped, replaced by the existing
file in a file field or left over by cancelling the modal were never
removed from the upload queue. The queue did not reach zero and the
upload was never finished: the Media module did not offer to reload
and the file browser did not show the uploaded files.

Additionally, closing the modal announced the upload as finished
while the uploads chosen in it were still running, so the file
browser refreshed its list too early.

Every file that is not uploaded now leaves the queue, and the upload
is announced as finished only once the queue is empty.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 78

  1. Oli Bartsch uploaded patch set 1 10/21/26, 19:28

  2. core-ci voted on patch set 1 V +1 10/21/26, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112039

  3. Josua Vogel voted on patch set 1 CR +1 V +1 10/22/26, 20:35

  4. Benni Mack voted on patch set 1 CR +1 V +1 10/22/26, 20:40

  5. Wouter Wolters voted on patch set 1 CR +1 V +1 10/22/26, 20:47

  6. Georg Ringer voted on patch set 1 CR +1 V +1 10/22/26, 20:50

  7. Georg Ringer voted on patch set 1 CR +2 V +2 10/23/26, 05:32

  8. Georg Ringer merged patch set 2 10/23/26, 05:59