Review main Merged

97096[TASK] Test configured IP anonymization masks

Wouter Wolters CR +2 V +2 Easy +8 −3 updated 10/28/26, 15:29

Commit message

The IP anonymization tests only cover configured mask 1 when the
explicit mask is null. An implementation that always falls back to 1
could therefore pass.

Add IPv4 and IPv6 cases for configured masks 0 and 2. Back up global
state so each test restores the configuration it changes.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Wouter Wolters uploaded patch set 1 10/24/26, 07:08

  2. Wouter Wolters rebased onto patch set 2 10/24/26, 07:14

  3. core-ci voted on patch set 1 V -1 10/24/26, 07:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112400

  4. core-ci voted on patch set 2 V +1 10/24/26, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112402

  5. Oliver Klee voted on patch set 2 V +1 10/24/26, 09:09

  6. Benni Mack voted on patch set 2 CR +2 V +2 10/28/26, 15:29

  7. Benni Mack merged patch set 3 10/28/26, 15:29