Review main Merged

97174[BUGFIX] Prevent ambiguous column reference in menu_categorized_content

Garvin Hicking CR +2 V +2 Normal +124 −2 updated 10/28/26, 09:20

Commit message

The query of the "Categorized content" element joins
sys_category_record_mm, but referenced its columns `tablenames`,
`fieldname` and the tt_content `uid` without a table name. As soon
as tt_content has a column `tablenames` or `fieldname` (e.g. inline
fields using foreign_table_field), or sys_category_record_mm gets a
`uid` column, the query fails with an ambiguous column error.

All these columns are now qualified with their table.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1114

  1. Garvin Hicking uploaded patch set 1 10/27/26, 09:14

  2. Garvin Hicking uploaded patch set 2 10/27/26, 09:21

  3. core-ci voted on patch set 1 V +1 10/27/26, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112639

  4. core-ci voted on patch set 2 V +1 10/27/26, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112640

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 10/27/26, 09:43

  6. Guido Schmechel voted on patch set 2 CR +1 V +1 10/27/26, 09:54

  7. Oliver Klee voted on patch set 2 CR +1 V +1 10/27/26, 10:49

  8. Sebastian Iffland voted on patch set 2 CR +1 10/27/26, 14:54

  9. Wouter Wolters voted on patch set 2 CR +1 V +1 10/27/26, 21:33

  10. Oli Bartsch uploaded patch set 3 CR +1 V +1 10/27/26, 21:52

  11. Oli Bartsch voted on patch set 3 CR +1 V +1 10/27/26, 21:53

  12. core-ci voted on patch set 3 V +1 10/27/26, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112665

  13. Garvin Hicking voted on patch set 3 CR +2 V +2 10/27/26, 22:24

  14. Garvin Hicking merged patch set 4 10/28/26, 09:20