97201[BUGFIX] Respect error code when determining sys_log level
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Wouter Wolters +1
-
Verified V +2 Done
- Oli Bartsch +2
- Wouter Wolters +1
Issues 1
Files 4
Review log 1115
-
Johannes Kasberger uploaded patch set 1 10/28/26, 16:03
-
core-ci voted on patch set 1 V +1 10/28/26, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112737
-
Markus Klein updated the commit message in patch set 2
V +110/28/26, 16:45 -
Markus Klein voted on patch set 2 CR +1 V +1 10/28/26, 16:46
-
core-ci voted on patch set 2 V +1 10/28/26, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112742
-
Oli Bartsch commented on patch set 2 10/28/26, 21:11
Hey, thanks for the patch! Works well, I added two comments regarding the error level matching and missing test.Type.php:62Please map `USER_ERROR` to `LogLevel::WARNING` instead of `error`. It's used at >100 call sites for user-caused refusals such as missing permissions, and belog already shows a warning icon for errors. `LogEntryRepository.php` also calls it "warning (user problem)". Otherwise the "at least error" filter fills up with routine permission denials, and setups monitoring `level = 'error'` would see a jump in volume. Keep `SYSTEM_ERROR` as `error` and `WARNING` as `warning`, and please explain the mapping in the commit message. If you prefer `error` for `USER_ERROR`, we should fix the docblock as well.Type.php:92Could you please add a unit test, since this is a pure static function. A data provider covering these cases would pin the mapping and the "only raise, never lower" rule, like `DB` + `MESSAGE` => `info`, `DB` + `SYSTEM_ERROR` => `error`, etc. -
Johannes Kasberger uploaded patch set 3
CR +1V +110/30/26, 11:56 -
Johannes Kasberger commented on patch set 3 10/30/26, 12:00
Reply
Both changes are added. I think I would be surprised to learn that USER_ERRORS are logged as a warning but since this type is used so often it would be also not great to get so many errors.Type.php:62ReplyDoneType.php:92ReplyDone -
core-ci voted on patch set 3 V +1 10/30/26, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112869
-
Oli Bartsch updated the commit message in patch set 4
V +110/30/26, 21:17 -
Oli Bartsch commented on patch set 4 CR +1 V +1 10/30/26, 21:17
Reply
AcknowledgedHey, thanks again for your patch! Works great. Just removed v13 as this is not considered a priority bugfix. -
Wouter Wolters voted on patch set 4 CR +1 V +1 10/30/26, 21:25
-
Oli Bartsch voted on patch set 4 CR +2 V +2 10/30/26, 21:26
-
Oli Bartsch merged patch set 5 10/30/26, 21:26
-
core-ci voted on patch set 4 V +1 10/30/26, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112911