Review main Merged

97227[BUGFIX] Keep original file when extracting plain text

Benni Mack CR +2 V +2 Normal +47 −14 updated 10/30/26, 10:15

Commit message

PlainTextExtractor read the file through getForLocalProcessing(false)
and removed the returned path afterwards whenever its base name
differed from the name of the file, assuming it was a temporary copy
of a remote file. For a local storage this path is the original file,
which got deleted if the name stored in sys_file differed from the
name in the storage.

The text is now read with getContents(), which works for local and
remote storages and does not leave a temporary file behind.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Daniel Windloff +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Daniel Windloff +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 10/30/26, 09:11

  2. core-ci voted on patch set 1 V +1 10/30/26, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112839

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 10/30/26, 09:49

  4. Daniel Windloff voted on patch set 1 CR +1 V +1 10/30/26, 10:00

  5. Benni Mack voted on patch set 1 CR +2 V +2 10/30/26, 10:15

  6. Benni Mack merged patch set 2 10/30/26, 10:15