Review 14.3 Merged

97396[DOCS] Explain matching of Respect GET Parameters

Garvin Hicking CR +2 V +2 Normal +52 −2 updated 11/06/26, 20:16

Commit message

The redirects manual claimed that the option only decides whether query
parameters are matched. Without a regular expression it has to fit the
source path, otherwise the redirect never matches, and with a regular
expression a disabled option matches against the path and the query
string as well.

The field stays necessary for regular expressions, so the manual now
explains both cases and shows the resulting matches in a table.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 11/06/26, 18:33

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/06/26, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113516

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 11/06/26, 20:16

  4. Garvin Hicking merged patch set 2 11/06/26, 20:16