Review main Merged

9755[FEATURE] Group task list in scheduler by extension

Philipp Gampe CR +2 V +2 Easy +16 −3 updated 06/03/13, 20:49

Commit message

To make the long drowdown more readable, group the task list in
schedular (Add Task) by extension and add the description as title
to the corresponding option tag.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Felix Kopp +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Felix Kopp +1

Issues 1

Files 1

Review log 5

  1. Tolleiv Nietsch commented on patch set 1 V 0 03/21/12, 18:54

    by team member; Looks good to me, approved Indeed - please use a second patchset (also relevant for 4.7) to sort the labels. This one worked fine :)
  2. Philipp Gampe commented on patch set 1 03/21/12, 18:54

    (1 inline comment)
  3. Felix Kopp commented on patch set 1 03/21/12, 18:54

    Verified; Looks good to me, but someone else must approve Sooo funny, have just be working on exactly this functionality.

    class.tx_scheduler_module.php:766

    The classInfos are not sorted as far as I can see, only the extension names. Would be better, what do you think?
  4. Mr. Jenkins commented on patch set 1 03/21/12, 18:54

  5. Tolleiv Nietsch merged patch set 1 03/21/12, 18:54