Review TYPO3_4-5 Merged

976[BUGFIX] tcaTree: make own record unselectable

Steffen Ritter CR +2 V +2 Easy +36 −1 updated 06/03/13, 20:49

Commit message

Relations to an own record is not useful. You could exclude is via tca "andWhere"
This is not nice, because you wouldn't  see the whole tree.
Just make the own record unselectable.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Jigal van Hemert +2
    • Oliver Hader +2
    • Stefan Neufeind +1
  • Verified V +2
    • Steffen Ritter +2
    • Jigal van Hemert +1

Issues 1

Files 3

Review log 9

  1. Stefan Neufeind commented on patch set 2 07/08/11, 12:04

    Looks good to me, but someone else must approve
  2. Oliver Hader commented on patch set 2 07/08/11, 12:04

    Looks good to me, approved
  3. Oliver Hader uploaded patch set 2 07/08/11, 12:04

  4. Steffen Ritter commented on patch set 2 07/08/11, 12:04

    Looks good to me, approved
  5. Jigal van Hemert commented on patch set 1 07/08/11, 12:04

    Verified; Looks good to me, but someone else must approve The version for master is already in. Let's get it into 4.5 too!
  6. Jigal van Hemert commented on patch set 2 07/08/11, 12:04

    Verified; Looks good to me, approved Had to vote again, even though *only* the commit message was changed.
  7. Mr. Jenkins commented on patch set 2 07/08/11, 12:04

  8. Steffen Ritter commented on patch set 2 V 0 07/08/11, 12:04

    by team member FYI: as it is already merged to master some month ago and there are some votes already I merged this one as bugfix to 4.5 to (codebase does not differ!)
  9. Steffen Ritter merged patch set 2 07/08/11, 12:04