Review main Merged

9763[TASK] Error reporting is set twice in bootstrap

Andy Grunwald CR +2 V +2 Easy +0 −5 updated 06/03/13, 20:49

Commit message

In index.php AND typo3/sysext/cms/tslib/index_ts.php
(which will be included in index.php) the error reporting
is set to E_ALL ^ E_NOTICE ^ E_DEPRECATED.

The set command in typo3/sysext/cms/tslib/index_ts.php is
obsolete, because this has no further effect.
This will be set in the previous index.php as well.

Result: Less code to maintain

See also #35003, #35017 and #35019

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andy Grunwald +1
  • Verified V +2
    • Christian Kuhn +2
    • Andy Grunwald +1

Files 1

Review log 12

  1. Tolleiv Nietsch commented on patch set 2 04/11/12, 12:32

    Verified; Looks good to me, but someone else must approve
  2. Tolleiv Nietsch commented on patch set 2 04/11/12, 12:32

    Looks good to me, approved
  3. Stefan Neufeind commented on patch set 2 04/11/12, 12:32

    Looks good to me, but someone else must approve looks okay be reading source and your arguments
  4. Oliver Klee commented on patch set 2 04/11/12, 12:32

    Looks good to me, but someone else must approve
  5. Christian Kuhn uploaded patch set 3 04/11/12, 12:32

  6. Christian Kuhn uploaded patch set 4 04/11/12, 12:32

  7. Andy Grunwald uploaded patch set 2 04/11/12, 12:32

  8. Andy Grunwald commented on patch set 4 04/11/12, 12:32

    Verified; Looks good to me, but someone else must approve Wohooooo!
  9. Mr. Jenkins commented on patch set 1 04/11/12, 12:32

  10. Mr. Jenkins commented on patch set 2 04/11/12, 12:32

  11. Christian Kuhn commented on patch set 4 V 0 04/11/12, 12:32

    by team member; Looks good to me, approved
  12. Christian Kuhn merged patch set 4 04/11/12, 12:32