Review main Merged

9827[BUGFIX] Use state "excludeFromUpdates" in update check

Jigal van Hemert CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Do not offer update for extensions with state "excludeFromUpdates"

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Tolleiv Nietsch +1
    • Sebastian Fischer +1
    • Xavier Perseguers +1
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Galinski +2
    • Tolleiv Nietsch +1
    • Xavier Perseguers +1
    • Philipp Gampe +1

Files 1

Review log 7

  1. Tolleiv Nietsch commented on patch set 1 03/28/12, 21:08

    Verified; Looks good to me, but someone else must approve Removes the update icon on the "Available extensions" list but keeps it on the "Import extensions" - which is imho correct.
  2. Stefan Galinski commented on patch set 1 V 0 03/28/12, 21:08

    by team member; Looks good to me, approved Thanks Jigal!
  3. Xavier Perseguers commented on patch set 1 03/28/12, 21:08

    Verified; Looks good to me, but someone else must approve
  4. Sebastian Fischer commented on patch set 1 03/28/12, 21:08

    Looks good to me, but someone else must approve
  5. Philipp Gampe commented on patch set 1 03/28/12, 21:08

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 03/28/12, 21:08

  7. Stefan Galinski merged patch set 1 03/28/12, 21:08