Review main Merged

9860[BUGFIX] Results from live search and opendocs can't be opened

Felix Kopp CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Andy Grunwald +1
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Galinski +2
    • Wouter Wolters +1
    • Francois Suter +1
    • Christian Kuhn +1
    • Andy Grunwald +1
    • Philipp Gampe +1

Files 1

Review log 25

  1. Stefan Galinski commented on patch set 1 04/12/12, 14:49

    Fails; Do not submit This breaks the initial loading of the "remembered" last page if the pagetree is shown.
  2. Francois Suter commented on patch set 2 04/12/12, 14:49

    Fails I have found a situation where it does not work for me: if the page tree has not been displayed yet during the session, the behavior is still the broken one (i.e. click on the search result, see it get displayed under the loading mask, page tree finishes loading and swaps to current page). As soon as the page tree has been loaded at least once, the behavior is ok. I'm not sure how this concurrency issue can be solved. To reproduce the above situation is quite simple: change your user settings to start in a module that does not have the page tree, for example the Reports. Start a search as soon as you have finished logging in. You should observe the described behavior.
  3. Stefan Galinski uploaded patch set 2 04/12/12, 14:49

  4. Stefan Galinski commented on patch set 2 04/12/12, 14:49

    No score Please review this carefully, but it seems like this simple change fixes all(?) remaining issues with not loadable module content, because of instant pagetree refreshes. I'am not sure if the recentIds variable is used somewhere else that isn't pagetree related, but I don't expect that.
  5. Francois Suter commented on patch set 3 04/12/12, 14:49

    I'm not entirely sure if that works out as expected: the element opens fine in Edit mode (even in my special case where I don't start with a visible page tree), but the page on which the element is, does not get selected in the page tree. This means that when I quit editing, I find myself on a blank page, because no selection is active in the tree.
  6. Francois Suter commented on patch set 3 V 0 04/12/12, 14:49

    OK, then my +1 by testing (not by reading, I don't know this part of TYPO3 TBH).
  7. Stefan Galinski uploaded patch set 3 04/12/12, 14:49

  8. Stefan Galinski commented on patch set 3 04/12/12, 14:49

    Not related to this patch. This behaviour is part from one of the most-hated issues currently in the tracker if we look at the votes. Not that easy to fix, but should be possible with enough time. BTW: The reason for the blank page looks more like a missing return url parameter and seems like another bug. Feel free to report that issue, but I'am sure that this will be done from someone else soon after this patch will be committed. ;-)
  9. Stefan Galinski commented on patch set 3 04/12/12, 14:49

    @Sebastian: The tree works in native IE8 with and without the patch. @Wouter: I don't exactly know that you are meaning? The patch doesn't touches the pagetree filter at all. @all: Thanks for reviewing the patch, but a valid test and code review of a core member is still missing.
  10. Stefan Galinski commented on patch set 3 04/12/12, 14:49

    I found a solution to indicate the initial "origin" of the call. Someone has more corner cases? ;-)
  11. Stefan Galinski commented on patch set 3 V 0 04/12/12, 14:49

    by team member; Looks good to me, approved Just a small explanation: The change to -2 was done, because this value hasn't a special meaning for the pagetree and so it doesn't tries to reload the content frame. Also this code will be changed soon to correctly implement the path expansion of the tree. Stay tuned!
  12. Christian Kuhn commented on patch set 3 04/12/12, 14:49

    Verified; Looks good to me, but someone else must approve
  13. Sebastian Michaelsen commented on patch set 3 04/12/12, 14:49

    Verified; Looks good to me, but someone else must approve
  14. Sebastian Michaelsen commented on patch set 3 04/12/12, 14:49

    No score; No score Please check if this works in IE8. I used this patch for my client and the pagetree stopped working. Reverting the patch made the pagetree work again (the search was then broken again of course). I don't have an IE8 here locally, so I can't 100% confirm the problem.
  15. Philipp Gampe commented on patch set 1 04/12/12, 14:49

    Verified; Looks good to me, but someone else must approve Works for me (Chromium). Bookmark does work too.
  16. Philipp Gampe commented on patch set 3 04/12/12, 14:49

    Verified; Looks good to me, but someone else must approve
  17. Andy Grunwald commented on patch set 3 04/12/12, 14:49

    Verified; Looks good to me, but someone else must approve After testing, filtering (in pagetree), opening docs from search and openDocs window will work.
  18. Felix Kopp commented on patch set 3 04/12/12, 14:49

    Who has good knowledge of the js dependencies. Any news here?
  19. Mr. Jenkins commented on patch set 1 04/12/12, 14:49

  20. Mr. Jenkins commented on patch set 2 04/12/12, 14:49

  21. Mr. Jenkins commented on patch set 3 04/12/12, 14:49

  22. Wouter Wolters commented on patch set 3 04/12/12, 14:49

    I just had a look at IE8 and without the patch the pagetree filter is not working. It gives an error that the method or propertie is not supported by the object. The patch is working fine.
  23. Wouter Wolters commented on patch set 3 04/12/12, 14:49

    @stefan I mean the pagetree filter was not working for me on IE8, without the patch. So this patch doesn't touch the pagetree, but Sebastian asked if this patch was related to the problem he encountered in a website after applying this patch for a client. So I guess that is another issue...
  24. Wouter Wolters commented on patch set 3 04/12/12, 14:49

    Verified; Looks good to me, but someone else must approve
  25. Stefan Galinski merged patch set 3 04/12/12, 14:49