9932[BUGFIX] Slider Wizard value not set when used in a flexform
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Claus Due +1
- Arjen Hoekema +1
-
Verified V +2
- Tolleiv Nietsch +2
- Arjen Hoekema +1
Files 1
Review log 11
-
Tolleiv Nietsch merged patch set 1 05/06/12, 20:21
-
Arjen Hoekema commented on patch set 1 05/06/12, 20:21
Verified; I would prefer that you didn't submit this IMHO the check on the fieldname "pi_flexform" should be removed, fields of type "flex" are not limited to the column "pi_flexform". Maybe there is a possibility to check whether the current field is of the type "flex"? Or maybe we can rely on "$params['flexFormPath']" for flexform field detection. -
Mr. Jenkins commented on patch set 1 05/06/12, 20:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3669/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/06/12, 20:21
I tested this patch with the test extension from http://forge.typo3.org/issues/25315 (current behavior) and using a flexform created with Flux. -
Arjen Hoekema commented on patch set 2 05/06/12, 20:21
Verified; Looks good to me, but someone else must approve Works for me. Also with custom columns with the type 'flex'. -
Tolleiv Nietsch commented on patch set 2 V 0 05/06/12, 20:21
by team member; Looks good to me, approved -
Claus Due commented on patch set 2 05/06/12, 20:21
Looks good to me, but someone else must approve Code looks good - no time to test, sorry. -
Mr. Jenkins commented on patch set 2 05/06/12, 20:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3686/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/06/12, 20:21
When using the slider in TCA the flexFormPath is empty. Hopefully someone more specialized in flexforms can have a look at this:) -
Wouter Wolters uploaded patch set 2 05/06/12, 20:21
-
Tolleiv Nietsch commented on patch set 2 05/06/12, 20:21
Hm oversaw that the slider wasn't part of 4.5 ... so this was only merged into 6.0, 4.7 and 4.6