Issue Bug Closed

#100016"X-Mailer: TYPO3" will be set many times

Ralph Brugger 02/23/23, 09:00 updated 03/14/23, 11:47

Description

We’re using a code like this:

/** @var MailMessage $email */
$this->email = GeneralUtility::makeInstance(MailMessage::class);

foreach ($recipientChunk as $recipient){

        $this->email
            ->to($recipient->getEmail())
            ->from($newsletter->getSender())
            ->replyTo($newsletter->getReplyTo())
            ->subject($newsletter->getSubject());
...
...
...
        $this->email
            ->html($htmlContent)
            ->text($textContent);
...
...
        $this->email->send();

}

We’re trying to instantiate as less as possible, so the MailMessage-Object is reused.

The problem is that the core (Mailer.php) does this:

    public function send(RawMessage $message, Envelope $envelope = null): void
    {
        ...
        $message->getHeaders()->addTextHeader('X-Mailer', $this->mailerHeader);

With each mail in the loop there will be a new “‘X-Mailer: TYPO3” added.
We’re having a loop with hundreds of recipients, so the header will get to large:

Reporting-MTA: dns; mgmt.***.backend
Diagnostic-Code: smtp; 552 5.6.0 Headers too large (32768 max)

It would better to check if the header ist set before:

        $headers = $message->getHeaders();
        if (! $headers->has('X-Mailer')){
            $headers->addTextHeader('X-Mailer', $this->mailerHeader);
        }

or

        $headers = $message->getHeaders();
        if (! $headers->has('X-Mailer')){
            $header->remove('X-Mailer');
        }
        $headers->addTextHeader('X-Mailer', $this->mailerHeader);

Reviews 2