Issue Task Rejected

#100082Improve performance of PageLinkBuilder

Christian Eßl 03/04/23, 12:04 updated 01/07/25, 14:10

Description

On pages with many links, the PageLinkBuilder can become pretty resource-intensive:

- Because we don’t know, which site or page tree the target page belongs to, we first need to fetch the $site object with $siteFinder->getSiteByPageId().
- Internally, this function then needs to recursively fetch the rootline, the target page uid belongs to.
- This needs to be done for every new page id, that we create a link for.

However, on single-site setups, we don’t need all this and can safely pass the rootline array, that has already been established in $tsfe. This simple check can save many unnecessary db requests at least for single-site setups.

Reviews 1

History 312

  1. Christian Kuhn commented and changed status Under Review Rejected <span data-processor="relativetime" data-value="2025-01-07T14:10:13+00:00" > 01/07/25, 14:10 </span>

    The patch did not work out as such and has been abandoned after a long time of being stalled. Closing here as ‘rejected’. If there is still room for improvements, we should probably start from scratch with a fresh issue.