#100082Improve performance of PageLinkBuilder
Description
On pages with many links, the PageLinkBuilder can become pretty resource-intensive:
- Because we don’t know, which site or page tree the target page belongs to, we first need to fetch the $site object with $siteFinder->getSiteByPageId().
- Internally, this function then needs to recursively fetch the rootline, the target page uid belongs to.
- This needs to be done for every new page id, that we create a link for.
However, on single-site setups, we don’t need all this and can safely pass the rootline array, that has already been established in $tsfe. This simple check can save many unnecessary db requests at least for single-site setups.
Reviews 1
Related issues 1
History 312
-
Gerrit Code Review pushed patch set 1 for main to change 78024 status
NewUnder Review <span data-processor="relativetime" data-value="2023-03-04T12:15:25+00:00" > 03/04/23, 12:15 </span> -
Gerrit Code Review pushed patch set 2 for main to change 78024 <span data-processor="relativetime" data-value="2023-03-07T20:30:41+00:00" > 03/07/23, 20:30 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 78024 <span data-processor="relativetime" data-value="2023-03-08T07:48:26+00:00" > 03/08/23, 07:48 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 78024 <span data-processor="relativetime" data-value="2023-03-08T09:32:24+00:00" > 03/08/23, 09:32 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 78024 <span data-processor="relativetime" data-value="2023-03-08T19:09:33+00:00" > 03/08/23, 19:09 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 78024 <span data-processor="relativetime" data-value="2023-03-08T20:30:31+00:00" > 03/08/23, 20:30 </span>
-
Christoph Lehmann changed Related to #100378 <span data-processor="relativetime" data-value="2023-04-01T10:45:04+00:00" > 04/01/23, 10:45 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 78024 <span data-processor="relativetime" data-value="2023-09-07T20:58:50+00:00" > 09/07/23, 20:58 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 78024 <span data-processor="relativetime" data-value="2023-10-23T08:15:06+00:00" > 10/23/23, 08:15 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 78024 <span data-processor="relativetime" data-value="2024-10-18T13:46:35+00:00" > 10/18/24, 13:46 </span>
-
Wolfgang Klinger commented <span data-processor="relativetime" data-value="2024-12-06T09:52:17+00:00" > 12/06/24, 09:52 </span>
-
Christian Kuhn commented and changed status
Under ReviewRejected <span data-processor="relativetime" data-value="2025-01-07T14:10:13+00:00" > 01/07/25, 14:10 </span>The patch did not work out as such and has been abandoned after a long time of being stalled. Closing here as ‘rejected’. If there is still room for improvements, we should probably start from scratch with a fresh issue.
For a single site installation, use my extension:
https://github.com/plan2net/single-site