Issue Feature Rejected

#100195Make Shortcut Target [shortcut] a required field for pages.doktype = 4 (Shortcut)

Sybille Peters 03/17/23, 09:00 updated 06/10/24, 15:30

Description

is a bit difficult to solve:

!!! If shortcut_mode != 0, the shortcut is not necessary. So we can’t just make it a required field in this case.
!!! If we add a displayCond (see below) and make it reuqired, we can’t switch from shortcut_mode = 0 to shortcut_mode != 0 and empty ‘shortcut’ (because due to the displayCond the form would be saved and this is prevented by the required)

1. shortcut should only be displayed if shortcut_mode=0
2. if displayed, shortcut should be required
3. ?? if a translation, empty shortcut seems to be ok as well (though other fields behave differently)

Thus, the following code cannot be used:

Configuration/TCA/Overrides/pages.php:

    // condition: show shortcut if shortcut_mode = 0
    $GLOBALS['TCA']['pages']['columns']['shortcut']['displayCond'] = 'FIELD:shortcut_mode:=:0';

    // override type "shortcut": make it a a required field
    $GLOBALS['TCA']['pages']['types'][(string)\TYPO3\CMS\Core\Domain\Repository\PageRepository::DOKTYPE_SHORTCUT]['columnsOverrides'] =
    [
        'shortcut' => [
            'config' => [
                'eval' => 'required',
            ],
        ],
    ];

Reviews 1

History 46

  1. Gerrit Code Review pushed patch set 3 for main to change 78145 status New Under Review 03/17/23, 09:10

  2. Gerrit Code Review pushed patch set 4 for main to change 78145 03/17/23, 09:11

  3. Sybille Peters changed status Under Review New 03/17/23, 12:43

  4. Sybille Peters changed description 03/17/23, 15:41

  5. Sybille Peters changed Related to #100194 03/20/23, 05:56

  6. Sybille Peters commented and changed status New Rejected 06/10/24, 15:30

    Closing now. This is not so easy to solve because the behaviour depends on shortcut_mode. Also, see comments in patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78145