Issue Task Closed

#100364Improve performance of PathUtility

Christian Eßl 03/31/23, 13:57 updated 03/27/25, 17:53

Description

No description.

Reviews 1

History 17

  1. Georg Ringer commented and changed status Under Review Closed <span data-processor="relativetime" data-value="2025-03-27T17:53:00+00:00" > 03/27/25, 17:53 </span>

    closing as no progress. see comment in gerrit

    If changes is postulated as performance related,
    it is eminant to provide proper benchmarking or
    some numbers and not only a percentage.
    
    20 percent - is that 1ms , is that 20 seconds ?
    
    Also, what does "called several thousand of times" ?
    
    To be honest, I did not profiled the backend and the
    amount of calls in the file list module, but I did
    a simplified benchmark and comparision of the method
    call with and without this change (with the included
    bug).
    
    Here is the GIST with the cli command, some output
    and a conclusion at the end:
    
    https://gist.github.com/sbuerk/ceb78259fc495a13efcd2af2b7ecd4d1
    
    50000 calls: 5ms
    500000 calls: 25ms (taking slowest from current againsts fasted fro change the diff is only 36ms)
    
    I'd guess that if these number of method calls are hit, specially the 500k one,
    you have other issues in the backend than that. Beside that, 25ms would be okay
    for that amount.
    
    To be honest - I'd did no profiling and countent usual or casual amount of
    method calls - do you have real numbers of it in current core versions (v12/main)
    
    Taking these numbers I'd would stay away from reworking this method,
    as the try showed it is not that easy without introducing side effects
    or bugs. Thus, I would stay with the proven to work implementation instead
    of taking the risk.
    
    I'm open for a more comprehensive and detailed benchmark - looking on the watch, I may have made some errors with it.