Issue Bug Closed

#100750Backend search does not work if user has too many searchable webmounts

Kai Strecker 04/25/23, 12:20 updated 07/09/24, 12:56

Description

Info: This affects the search in top-right corner of the backend, after clicking on the “Show all” button, if an editor user has too many searchable webmounts.

The id list returned by typo3_src/typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php->getSearchableWebmounts can contain ids multiple times.

We encountered a problem in a large TYPO3 system where this function returned about 78000 ids instead of about 2300 unique ids for an editor. This led to the error, that the sql query in DatabaseRecordList.php->getTable executed by $queryBuilderTotalItems had too many placeholders.

In my opinion, this bug can be easily fixed, by calling array_unique on the id list before saving it to the runtime cache and returning it from the function.

https://github.com/TYPO3-CMS/recordlist/blob/main/Classes/RecordList/DatabaseRecordList.php#L2860

Reviews 5

History 35

  1. Gerrit Code Review pushed patch set 1 for main to change 78873 status New Under Review 04/26/23, 07:05

  2. Gerrit Code Review pushed patch set 1 for 11.5 to change 78874 04/26/23, 07:05

  3. Andreas Fernandez commented and changed status Under Review Resolved done 0 % 100 % 04/27/23, 14:00

    Applied in changeset commit:0fd1cfacd20be07bb16ad6232d1a8625bcc1048c.

  4. Andreas Kienast changed Related to #101200 06/29/23, 14:13

  5. Benni Mack changed status Resolved Closed 07/09/24, 12:56