#100929Typoscript config controlsList=nodownload not possible!
Description
Typoscript config not possible:
lib.contentElement.settings.media.additionalConfig.controlsList=nodownload
rendering will give 2 attributes
Reason is a doublet Foreach in \TYPO3\CMS\Core\Resource\Rendering\VideoTagRenderer::render-Method
if (isset($options['additionalConfig']) && is_array($options['additionalConfig'])) {
foreach ($options['additionalConfig'] as $key => $value) {
if ((bool)$value) {
$attributes[] = htmlspecialchars($key);
}
}
}
foreach (['class', 'dir', 'id', 'lang', 'style', 'title', 'accesskey', 'tabindex', 'onclick', 'controlsList', 'preload'] as $key) {
if (!empty($options[$key])) {
$attributes[] = $key . '="' . htmlspecialchars($options[$key]) . '"';
}
}Reviews 2
History 714
-
Heiko Dietrich commented 05/30/23, 09:52
-
Oliver Hader changed status
NewAccepted 05/30/23, 11:08 -
Oliver Hader changed category 05/30/23, 11:08
-
Benni Mack changed Sprint Focus Stabilization Sprint 06/06/23, 12:49
-
Gerrit Code Review pushed patch set 1 for main to change 79615 status
AcceptedUnder Review 07/03/23, 13:41 -
Gerrit Code Review pushed patch set 2 for main to change 79615 07/03/23, 16:59
-
Gerrit Code Review pushed patch set 3 for main to change 79615 07/03/23, 16:59
-
Gerrit Code Review pushed patch set 4 for main to change 79615 07/03/23, 17:04
-
Gerrit Code Review pushed patch set 5 for main to change 79615 07/03/23, 17:05
-
Gerrit Code Review pushed patch set 1 for 12.4 to change 79638 07/03/23, 19:53
-
Benni Mack commented and changed status
Under ReviewResolved done0 %100 % 07/03/23, 19:55Applied in changeset commit:dc06661c1c3b6fafce8b351496d889814d707f86.
-
Gerrit Code Review pushed patch set 2 for 12.4 to change 79638 status
ResolvedUnder Review 07/04/23, 07:15 -
Benni Mack commented and changed status
Under ReviewResolved 07/04/23, 07:35Applied in changeset commit:96877af6a713f4db45b0e452ea5e601d1c281ee1.
-
Benni Mack changed status
ResolvedClosed 07/09/24, 14:15
Easiest solution couldt be, if use:
instead of