Issue Task Closed

#101621Make frontend meta tag twitter:card optional

Patrick Lenk 08/08/23, 15:58 updated 07/09/24, 14:15

Description

The meta tag “twitter:card” should be optional. I would assume that a TypoScript such as page.meta.twitter:card > or page.meta.twitter_card > removes the meta tag in frontend. But this does not work, because ext:seo always add this to the meta tags.

The main problem in my opinion is, that there is no empty/none option to check in Line 84 in /seo/Classes/MetaTag/MetaTagGenerator.php always added.

(Since twitter is X, it should be optional more than ever…)

Reviews 2

History 68

  1. Patrick Lenk changed PHP Version 8.2 8.1 08/08/23, 15:59

  2. Kevin Appelt commented and changed status New Needs Feedback 09/13/23, 09:56

    1. Even if we add a check around it, it’s most probably set.
      @twitter_card@ is a select field with the options summary and summary_large and the default of summary.
      So if nothing is changed, the value will be summary, the condition will become true and the meta tag gets rendered.
    2. twitter:card is still the valid and official meta tag, according to the X Developer Platform (see: https://developer.twitter.com/en/docs/twitter-for-websites/cards/guides/getting-started#started)
    3. AFAIK twitter assumes summary if nothing is set, so it wouldn’t make a difference to remove it.

    What is the specific use case for which you want to remove the meta tag? Maybe this will help to understand the requirement better and offer a solution.

  3. Patrick Lenk commented 09/13/23, 10:26

    Thanks for your feedback. Yes without an none option, the tag is always added. There are many reasons to not force the twitter meta tag. In my case most of them are political or ethical. I just don’t want to add anything from this company to my sites anymore. It should just configurable or optional like mostly all other things in TYPO3.

  4. Gerrit Code Review pushed patch set 1 for main to change 84622 status Needs Feedback Under Review 06/11/24, 16:57

  5. Gerrit Code Review pushed patch set 2 for main to change 84622 06/11/24, 17:54

  6. Georg Ringer commented and changed status Under Review Resolved done 0 % 100 % 06/13/24, 13:40

    Applied in changeset commit:f896c3df6a75ca35ce5da69f5ddb30dc75d6d768.

  7. Christian Kuhn changed Related to #104097 06/20/24, 16:27

  8. Benni Mack changed status Resolved Closed 07/09/24, 14:15