Issue Bug Closed

#102001ModifyUrlForCanonicalTagEvent misses the current request or information about the page

Benni Mack 09/21/23, 19:57 updated 07/09/24, 15:19

Description

No description.

Reviews 2

History 512

  1. Gerrit Code Review pushed patch set 2 for main to change 81164 status New Under Review 09/21/23, 19:57

  2. Benni Mack changed Related to #99807 09/21/23, 19:57

  3. Gerrit Code Review pushed patch set 3 for main to change 81164 09/21/23, 20:28

  4. Gerrit Code Review pushed patch set 4 for main to change 81164 09/21/23, 20:43

  5. Gerrit Code Review pushed patch set 5 for main to change 81164 12/04/23, 11:55

  6. Gerrit Code Review pushed patch set 6 for main to change 81164 12/04/23, 16:21

  7. Gerrit Code Review pushed patch set 7 for main to change 81164 12/04/23, 17:03

  8. Gerrit Code Review pushed patch set 1 for 12.4 to change 82021 12/04/23, 18:13

  9. Benni Mack commented and changed status Under Review Resolved done 0 % 100 % 12/04/23, 18:15

    Applied in changeset commit:171ef87fe474ee2156a5d069e48a4638a8c61421.

  10. Philipp Parzer commented 12/13/23, 14:23

    Minor Update breaks now on TYPO3 Instances that extend generate() function from CanonicalGenerator

  11. Benni Mack commented 12/14/23, 08:37

    Philipp Parzer wrote in #note-10:
    > Minor Update breaks now on TYPO3 Instances that extend generate() function from CanonicalGenerator

    Yes. The class is marked as internal, and XCLASS isn’t covered by the backwards-compatibility. Also, there is a PSR-14 event directly in this class, can you elaborate why you needed to extend this class in the first place?

    Could you fix this in your project or is your use-case a common scenario for people to extend this class?

  12. Benni Mack changed status Resolved Closed 07/09/24, 15:19