Issue Bug Closed

#102083Validation triggered for fields in fieldsets disabled by variants

Mathias Brodala 10/04/23, 10:03 updated 07/09/24, 15:19

Description

Given fields are placed in a fieldset and that fieldset is disabled using variants. Also given that these fields have validators.

Now if one tries to submit the form, it is displayed again without explanation. Inspection of the validation results shows that the validators of the fields have been triggered and couldn’t validate the input of the fields. These fields could not be filled by the user since they are disabled together with their fieldset.

Validators of fields within disabled fieldsets should be ignored.

Reviews 2

History 613

  1. Gerrit Code Review pushed patch set 1 for main to change 81318 status New Under Review 10/04/23, 10:10

  2. Gerrit Code Review pushed patch set 2 for main to change 81318 10/04/23, 10:10

  3. Gerrit Code Review pushed patch set 3 for main to change 81318 10/04/23, 12:18

  4. Gerrit Code Review pushed patch set 4 for main to change 81318 10/04/23, 12:19

  5. RVVN no-lastname-given commented 10/05/23, 19:03

    Could it be fixed for TYPO3v11 too ?

  6. Mathias Brodala commented 10/09/23, 07:14

    Unfortunately no, since this is no priority bugfix. But you can always apply this as patch to your instance.

  7. RVVN no-lastname-given commented 10/11/23, 16:54

    Mathias Brodala wrote in #note-6:
    > Unfortunately no, since this is no priority bugfix. But you can always apply this as patch to your instance.

    We use legacy installation so we cannot “composer patch” (if you were talking about that way).

    What defines “priority bugfix” ?
    If the fix can be applied to v11 (which is the version set in this issue) LTS , why don’t apply it ? :)

  8. Mathias Brodala commented 10/12/23, 07:09

    RVVN no-lastname-given wrote in #note-7:
    > Mathias Brodala wrote in #note-6:
    > > Unfortunately no, since this is no priority bugfix. But you can always apply this as patch to your instance.
    >
    > We use legacy installation so we cannot “composer patch” (if you were talking about that way).

    Then I strongly recommend to switch to Composer Mode ASAP.

    > What defines “priority bugfix” ?
    > If the fix can be applied to v11 (which is the version set in this issue) LTS , why don’t apply it ? :)

    This is not something I made up, see https://typo3.org/cms/roadmap

    In other words: I’d happily have this merged into TYPO3v11 too, but the decision is not mine to make.

  9. Gerrit Code Review pushed patch set 5 for main to change 81318 11/27/23, 14:27

  10. Gerrit Code Review pushed patch set 6 for main to change 81318 11/27/23, 20:40

  11. Gerrit Code Review pushed patch set 1 for 12.4 to change 82004 11/29/23, 04:32

  12. Mathias Brodala commented and changed status Under Review Resolved done 0 % 100 % 11/29/23, 04:45

    Applied in changeset commit:478d85d55734f79e935a3d67f0660a93f5a2f3a9.

  13. Benni Mack changed status Resolved Closed 07/09/24, 15:19