#102162AbstractMenuContentObject overrides addQueryString with 1
Description
In TYPO3 12, “addQueryString” config parameter has been extended: It can now be set to “untrusted” to keep all query params. (Value “1” would remove all query params that are not defined in a route enhancer.)
In TS configuration for LanguageMenuProcessor I can use the new value to enable keeping all query parameters:
dataProcessing.10 = language-menu
dataProcessing.10 {
languages = auto
as = languageNavigation
addQueryString = untrusted
}
Unfortunately, the “untrusted” value gets overridden when AbstractMenuContentObject::menuTypoLink(…) is called later. See line 1645 ff:
if ($page['_ADD_GETVARS'] ?? false) {
$conf['addQueryString'] = 1;
$conf['addQueryString.'] = $this->conf['addQueryString.'] ?? [];
}
('_ADD_GETVARS' is set to $this->conf['addQueryString'] ?? false in line 616.)
I suppose to change line 1645 ff to:
if ($page['_ADD_GETVARS'] ?? false) {
$conf['addQueryString'] = $page['_ADD_GETVARS'];
$conf['addQueryString.'] = $this->conf['addQueryString.'] ?? [];
}Reviews 2
Files 1
History 35
-
Sascha Ternes commented and changed attached t3-frontend-bugfix-add-query-string.patch 10/13/23, 12:00
-
Gerrit Code Review pushed patch set 1 for main to change 81424 status
NewUnder Review 10/13/23, 13:14 -
Gerrit Code Review pushed patch set 1 for 12.4 to change 81351 10/15/23, 14:13
-
Patrick Schriner commented and changed status
Under ReviewResolved done0 %100 % 10/15/23, 14:26Applied in changeset commit:8bde18dbb5fa551978e1309d5c770c9ef74811bb.
-
Benni Mack changed status
ResolvedClosed 07/09/24, 15:19
supposed patch